-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[autoscaler] Autoscaler metrics #16066
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
46ea81b
initial
ckw017 7c7cd1a
sanity check
ckw017 f170974
lint and more
ckw017 4150bf0
remove extra file?
ckw017 771b304
format
ckw017 3f11bc6
store ip of machine running monitor process
ckw017 eb9edb1
autoscaler_ip -> monitor_ip
ckw017 b4130a8
lint
ckw017 09a8998
add worker startup time buckets
ckw017 849c1ba
better descriptions
ckw017 6f58b81
more lint
ckw017 9050bab
propogate exception when starting prom http
ckw017 7be69c1
lint
ckw017 8f682b4
fix redis set/get
ckw017 51f7a5c
move start_http to monitor.py
ckw017 4259ecd
break up exception types and add pending_nodes metric
ckw017 bb9896e
Adjust buckets, fix test_autoscaler failures
ckw017 091610a
Add metric_agent tests
ckw017 ee005b1
explain _AUTOSCALER_METRICS
ckw017 1d82167
add basic exception count checks
ckw017 a43b38e
more autoscaler metric tests
ckw017 25f55dc
less dangerous way to handle no prom_metrics
ckw017 f7013c2
more mock checks
ckw017 b2bd1e5
better docs
ckw017 a0c10f0
nits
ckw017 c069b8c
cases for started_nodes and worker_startup_time histogram
ckw017 2c18da5
add node_launch_exceptions case
ckw017 216060c
use waitFor
ckw017 377d2c8
don't start http server if monitor_ip isn't provided
ckw017 0f1a6b2
drop worker_startup_time
ckw017 a6cc229
lint
ckw017 2edcb1a
Hotfix [nodes -> workers] + [count failed nodes as stopped]
ijrsvt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also increment
![Screen Shot 2021-05-31 at 3 06 04 PM](https://user-images.githubusercontent.com/21353794/120245351-bb7a5d00-c221-11eb-9422-ea38f4705148.png)
self.prom_metrics.stopped_nodes.inc()
here: