Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Add multi-node, multi-GPU SGD release test #16046

Merged
merged 5 commits into from
May 31, 2021
Merged

[Release] Add multi-node, multi-GPU SGD release test #16046

merged 5 commits into from
May 31, 2021

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented May 25, 2021

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

krfricke
krfricke requested changes May 25, 2021
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but left a couple of minor comments

release/nightly_tests/sgd_gpu/sgd_gpu_app_config.yaml Outdated Show resolved Hide resolved
release/nightly_tests/nightly_tests.yaml Outdated Show resolved Hide resolved
release/nightly_tests/sgd_gpu/sgd_gpu_test.py Outdated Show resolved Hide resolved
@amogkam
Copy link
Contributor Author

amogkam commented May 27, 2021

Thanks for the review! Comments are addressed

@amogkam amogkam requested a review from krfricke May 27, 2021 00:29
krfricke
krfricke approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardliaw richardliaw merged commit da6f28d into ray-project:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

Assignees

@richardliaw richardliaw

@krfricke krfricke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amogkam @krfricke @richardliaw