-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RayClient][Proxy] BugFixes #16040
[RayClient][Proxy] BugFixes #16040
Conversation
""" | ||
if self.redis_address: | ||
return self.redis_address | ||
connection_tuple = ray.init(address=self.redis_address) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this start a ray driver?
If yes, why do we need to pass self.redis_address to address? if the if statement did not happen, doesn't it mean that the value here is None?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, this will be None
. The logic is the same, but it is quite weird!
Locally run MacOS tests:
|
|
Why are these changes needed?
python -m ray.util.client.server
without starting Ray first does not work.ray.util.client.server
is the main process (as opposed to the shim process)Related issue number
Closes #16067
Checks
scripts/format.sh
to lint the changes in this PR.