Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect call function WorkerID::FromBinary #15449

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Fix incorrect call function WorkerID::FromBinary #15449

merged 1 commit into from
Apr 22, 2021

Conversation

Catch-Bull
Copy link
Contributor

@Catch-Bull Catch-Bull commented Apr 22, 2021 •
edited
Loading

Why are these changes needed?

The original code node_manger.cc incorrectly uses WokrerID::FromBinary to construct NodeID.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

raulchen
raulchen approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raulchen raulchen merged commit 5403021 into ray-project:master Apr 22, 2021
@raulchen raulchen deleted the Fix-incorrect-use-of-WorkerID_FromBinary branch April 22, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulchen raulchen raulchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Catch-Bull @raulchen