Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing __init__ for wheels #14615

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Mar 11, 2021

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ericl
Copy link
Contributor Author

ericl commented Mar 11, 2021

Build seems sane so merging as hotfix

@ericl ericl merged commit 081c960 into ray-project:master Mar 11, 2021
@waleedkadous
Copy link
Contributor

@ericl Can you help me understand how this passed tests?

Can we write a test to prevent this happening in future?

@ericl
Copy link
Contributor Author

ericl commented Mar 11, 2021

@simon-mo the issue as I understand is that it was a problem in the wheel upload process. Is it possible to add some sanity check to the wheel build job that tests you can install / ray.init() a wheel?

@simon-mo
Copy link
Contributor

simon-mo commented Mar 11, 2021 via email

@ericl
Copy link
Contributor Author

ericl commented Mar 11, 2021

Got it, so it was just my fault not checking the wheel status here. It infrequently breaks so I tend to ignore it :)

Separately, I think downstream consumers of nightly should run sanity checks (import ray; ray.init()) before auto ingesting new nightly builds.

@waleedkadous
Copy link
Contributor

Can we communicate when it fails more effectively, e.g. have it send an e-mail / page when it happens? I can't see from the code where buildkite failures are surfaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants