Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the --java-worker-options parameter #14563

Merged

Conversation

Catch-Bull
Copy link
Contributor

Why are these changes needed?

We've enabled multi-tenancy. We can now pass JVM options via job config. We can remove the --java-worker-options parameter.

Related issue number

Closes #12034

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

python/ray/_private/services.py Outdated Show resolved Hide resolved
python/ray/cloudpickle/__init__.py Outdated Show resolved Hide resolved
python/ray/cloudpickle/cloudpickle.py Outdated Show resolved Hide resolved
@kfstorm
Copy link
Member

kfstorm commented Mar 9, 2021

@pcmoritz Is it OK to delete a hidden parameter of ray start?

@Catch-Bull Catch-Bull requested a review from kfstorm March 9, 2021 11:57
@pcmoritz
Copy link
Contributor

pcmoritz commented Mar 9, 2021

@kfstorm This change looks good to me, thanks for checking back :)

@kfstorm kfstorm merged commit dfcb9c3 into ray-project:master Mar 10, 2021
@kfstorm kfstorm deleted the remove_parameter_java-worker-options branch March 10, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the --java-worker-options parameter
3 participants