Revert "Revert "Support accessing underlying attributes in RayTaskErr… #14449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors (ray-project#9210)" (ray-project#9263)" This reverts commit bfb8a28.
8e16ef5
to
3c5ce8f
Compare
|
@ericl anything special I need to do here for Ray client? |
|
Probably not. If you want test coverage, you could add something to test_basic which is run in client mode tests. |
simon-mo
approved these changes
Mar 4, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to interact with RayTaskError exception objects as they would with the underlying exception object. This makes it easier to convert existing code to run on Ray.
The only downside here is if the original object is not serializable, this will throw a separate exception with a traceback saying it couldn't be serialized. I don't see this being a significant issue because exception objects should generally be simple and not contain e.g., mutexes, but we can handle it here by only storing the traceback for non-serializable objects if need be.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.