[Core] Initialize system config in CoreWorkerProcess constructor #14439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
approved these changes
Mar 3, 2021
Comment on lines
143
to
152
| class ConfigInterface { | ||
| public: | ||
| /// Get the system config from Raylet. | ||
| /// \param callback Callback that will be called after raylet replied the system config. | ||
| virtual void GetSystemConfig( | ||
| const rpc::ClientCallback<rpc::GetSystemConfigReply> &callback) = 0; | ||
|
|
||
| virtual ~ConfigInterface(){}; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Can we just add this to the RayletClientInterface instead of adding a new one?
There was a problem hiding this comment.
Maybe we can fetch the job config here as well.
There was a problem hiding this comment.
Unless there's a concrete reason to have the interface right now (e.g., to support unit testing) let's omit it, excessive interfaces make making changes more difficult
There was a problem hiding this comment.
Ah, I didn't know these interfaces are for unit testing. Will update it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Some system config values may be accessed before connecting to Raylet in the
CoreWorkerconstructor, so we need to initialize the system config in theCoreWorkerProcessconstructor.Related issue number
Checks
scripts/format.shto lint the changes in this PR.