Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker] Fix docker 'development' build failure #13289

Merged
merged 4 commits into from
Feb 25, 2021
Merged

[docker] Fix docker 'development' build failure #13289

merged 4 commits into from
Feb 25, 2021

Conversation

ConeyLiu
Copy link
Contributor

@ConeyLiu ConeyLiu commented Jan 8, 2021 •
edited
Loading

Why are these changes needed?

This patch fixes the docker development build failed due to permissions issue.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo simon-mo requested a review from ijrsvt January 8, 2021 19:35
ijrsvt
ijrsvt reviewed Jan 8, 2021
View reviewed changes
Copy link
Contributor

@ijrsvt ijrsvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding this! We really appreciate it! Two small comments :)

docker/ray-deps/Dockerfile
@@ -9,6 +9,7 @@ ENV LANG=C.UTF-8
COPY $WHEEL_PATH .
RUN $HOME/anaconda3/bin/pip --no-cache-dir install $(basename $WHEEL_PATH)[all] \
$(if [ "$AUTOSCALER" = "autoscaler" ]; then echo \
"six==1.13.0" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ijrsvt, google-api-core requires six >= 1.13.0.

docker/development/Dockerfile Outdated Show resolved Hide resolved
@ijrsvt ijrsvt added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 8, 2021
@ijrsvt
Copy link
Contributor

ijrsvt commented Jan 8, 2021

Can you also update the description?

@ConeyLiu
Copy link
Contributor Author

Hi @ijrsvt, thanks for the review. Addressed comments and updated the description.

@ConeyLiu
Copy link
Contributor Author

cc @ijrsvt

ijrsvt
ijrsvt approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@ijrsvt ijrsvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijrsvt ijrsvt removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 25, 2021
@ijrsvt ijrsvt self-assigned this Feb 25, 2021
@ijrsvt ijrsvt changed the title Fixes docker development build failed [docker] Fix docker 'development' build failure Feb 25, 2021
@ijrsvt ijrsvt merged commit 34a9714 into ray-project:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijrsvt ijrsvt ijrsvt approved these changes

Assignees

@ijrsvt ijrsvt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ConeyLiu @ijrsvt