[Dashboard][Bugfix] Fix GPU List Bug #12666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ats instead of an empty list
rkooo567
approved these changes
Dec 9, 2020
|
This doesn't run the travis CI for some reason, can you try running it? |
rkooo567
added
the
@author-action-required
|
@rkooo567 I ran the changed test locally |
mfitton
added
tests-ok
|
Can you try push an empty commit or close-reopen this PR to trigger a build? |
mfitton
added a commit
that referenced
this pull request
Dec 21, 2020
* Fix bug where None was passed as the empty value for ActorInfo.gpu_stats instead of an empty list * lint * dashboard/modules/logical_view * fix test * trigger build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fixes issue #12554
Related issue number
Closes #12554
Checks
scripts/format.shto lint the changes in this PR.