Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard][Bug] Fix duplicate node total rows in dashboard #12410

Merged
merged 3 commits into from
Dec 1, 2020
Merged

[Dashboard][Bug] Fix duplicate node total rows in dashboard #12410

merged 3 commits into from
Dec 1, 2020

Conversation

mfitton
Copy link
Contributor

@mfitton mfitton commented Nov 25, 2020

Why are these changes needed?

Fix duplicate node total rows in dashboard by changing the react key of the NodeTotalRow component from the node IP to the node ID (node IP can be duplicated in the case of docker containers running on the same node).

Related issue number

Closes #12363

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@mfitton
Fix duplicate node total rows in dashboard by changing the react key …
33901fd 
…of the NodeTotalRow component from the node IP to the node ID (node IP can be duplicated in the case of docker).
@rkooo567
Copy link
Contributor

test_dashboard seems to timeout. Can you check out what's the problem?

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Nov 30, 2020
@mfitton
Copy link
Contributor Author

mfitton commented Nov 30, 2020

The autoscale dashboard endpoint test was failing due to timeout. I refactored a little bit, and it should fix the issue. Waiting on CI now.

@mfitton mfitton added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Nov 30, 2020
@rkooo567
Copy link
Contributor

rkooo567 commented Dec 1, 2020

This has bunch of failures from Windows tests. Do you happened to know why?

@rkooo567 rkooo567 merged commit 2708b3a into ray-project:master Dec 1, 2020
@mfitton mfitton mentioned this pull request Dec 1, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

Assignees

@rkooo567 rkooo567

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard] Duplicate IPs/Machine View Rows in dashboard
2 participants
@mfitton @rkooo567