Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin aiohttp to the 3.7.x version #12051

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

mfitton
Copy link
Contributor

@mfitton mfitton commented Nov 16, 2020

Why are these changes needed?

aiohttp has released a 4.0 build that changes some APIs and led to the dashboard breaking in the nightly. This pins the version so that we maintain a consistent API.

Related issue number

Closes #12049.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@stephanie-wang stephanie-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use < or <=?

@mfitton
Copy link
Contributor Author

mfitton commented Nov 17, 2020

@stephanie-wang I pinned it to 3.7 since the latest release (outside of the 4.0 alpha builds), is 3.7.2. 3.7 seems to work fine with Ray and will probably have the fewest vulnerabilities / issues. It also has the same api as the 3.6 version.

@mfitton mfitton added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Nov 17, 2020
@mfitton
Copy link
Contributor Author

mfitton commented Nov 17, 2020

It should be ready to merge. I don't have permissions to merge it myself, so I'd appreciate if you could Stephanie. I checked the tests to make sure they weren't related.

@stephanie-wang stephanie-wang merged commit 90574b6 into ray-project:master Nov 17, 2020
@stephanie-wang
Copy link
Contributor

It should be ready to merge. I don't have permissions to merge it myself, so I'd appreciate if you could Stephanie. I checked the tests to make sure they weren't related.

Thanks!

@mfitton mfitton deleted the pin-asyncio branch November 17, 2020 03:13
@fyrestone
Copy link
Contributor

Should we use < or <=?

@mfitton I think < is better. Pin the version may cause dependency conflicts. aiohttp is not a very popular package, so we haven't heard any complaints from users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verbose messages about new dashboard
3 participants