Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard][Bug] Fix page broken due to log/err count components #11954

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

mfitton
Copy link
Contributor

@mfitton mfitton commented Nov 11, 2020

Why are these changes needed?

These changes fix a dashboard regression caused by logCount and errCount being removed from worker payload in the PR to improve datacenter performance.

Related issue number

Closes #11932

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@mfitton mfitton added dashboard Issues specific to the Ray Dashboard bug Something that is supposed to be working; but isn't P0 Issues that should be fixed in short order labels Nov 11, 2020
@rkooo567 rkooo567 merged commit f545418 into ray-project:master Nov 11, 2020
@mfitton mfitton deleted the fix-log-count branch November 12, 2020 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't dashboard Issues specific to the Ray Dashboard P0 Issues that should be fixed in short order
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard] Blank screens when clicking on expand buttons
2 participants