Better checking that ray.init() has been called. #10261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just some linting errors. |
robertnishihara
force-pushed
the
checkinitialized
branch
from
bf30134
to
6ce1d9e
Compare
|
Rebasing to fix linting errors (which were not introduced by this PR I believe). |
|
Actually @sven1977 it's not just linting errors, the test added in this PR is failing on some of the builds. |
robertnishihara
commented
Aug 22, 2020
| "__version__", | ||
| "_config", | ||
| "_get_runtime_context", | ||
| "actor", | ||
| "actors", |
There was a problem hiding this comment.
Just making these more alphabetical.
robertnishihara
commented
Aug 22, 2020
| import ray | ||
|
|
||
|
|
||
| def test_errors_before_initializing_ray(): |
There was a problem hiding this comment.
I initially put this in test_basic.py, however, that has module level initialization with pytest, so ray was already initialized, and this test requires ray to be uninitialized.
robertnishihara
force-pushed
the
checkinitialized
branch
from
f01425d
to
2bf015b
Compare
ffbin
reviewed
Aug 25, 2020
| @@ -427,6 +429,9 @@ def get_resource_ids(): | |||
| each pair consists of the ID of a resource and the fraction of that | |||
| resource reserved for this worker. | |||
| """ | |||
| worker = global_worker | |||
There was a problem hiding this comment.
global_worker.check_connected() ? worker is not used later.
There was a problem hiding this comment.
I used
worker = global_worker
worker.check_connected()
because that's how it's done in the rest of this file. We should probably undo this at some point.
robertnishihara
force-pushed
the
checkinitialized
branch
from
2bf015b
to
24b6668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.