Prevent Local Worker creation from blocking remote worker creation by creating remote workers before local worker #10245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, sounds great. Thanks for the PR. @ericl: Any objections to the flipped order of doing things? |
|
Tests seem all fine. |
d0a58fb
to
1524acb
Compare
|
I accidentally pushed up change to format.sh (to use python3 instead of python) but removed that. |
ericl
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In my experiments, our environment can take ~1 minute to start up. I have noticed that the local worker blocks the creation of the remote workers. This means I end up paying 2 minutes for the environment startup. However, since the creation of the remote workers is non-blocking if we simply create them first we save this cost.
Checks
scripts/format.shto lint the changes in this PR.I have not created new tests for this since existing test makes sure the logic does not break and my local testing has shown that this speeds up experiment initialization.