Skip to content

Commit

Permalink
[core] skip all tests in test_actor_bounded_threads (#39553)
Browse files Browse the repository at this point in the history
The test aimed to test that as we handle more tasks the number of threads does not go up unbounded. However the test was a little too strict: some non-Ray threads (e.g. grpc, jemalloc) pops up and breaks the assertion.

Marking all tests tests as skipped, and will fix later.
  • Loading branch information
rynewang committed Sep 12, 2023
1 parent 3bb172d commit 67d7943
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions python/ray/tests/test_actor_bounded_threads.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
# actor should not infinitely go up.


@pytest.mark.skip(reason="Occational extra non-Ray threads, e.g. jemalloc")
def test_threaded_actor_have_bounded_num_of_threads(shutdown_only):
ray.init()

Expand Down Expand Up @@ -45,6 +46,7 @@ def fibonacci(a, i):
assert ray.get(a.my_number_of_threads.remote()) == n


@pytest.mark.skip(reason="Occational extra non-Ray threads, e.g. jemalloc")
def test_async_actor_have_bounded_num_of_threads(shutdown_only):
ray.init()

Expand Down Expand Up @@ -76,6 +78,7 @@ def fibonacci(a, i):
assert ray.get(a.my_number_of_threads.remote()) == n


@pytest.mark.skip(reason="Occational extra non-Ray threads, e.g. jemalloc")
def test_async_actor_cg_have_bounded_num_of_threads(shutdown_only):
ray.init()

Expand Down

0 comments on commit 67d7943

Please sign in to comment.