Use write_sql to write the embeddings #9
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ray-project/ray#38544 to write out the embeddings. This has some advantages: The user doesn't need to specify the parallelism, they don't need to trigger the computation with
.count()
, since a write is an action -- so this is less error prone. It is also less code.We should wait merging the PR until Ray 2.7 is released with ray-project/ray#38544 merged.