Fix potential memory leak

ray-cast · Sep 18, 2018 · bb49334 · bb49334
1 parent 6ea2068
commit bb49334
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/Baikal/SceneGraph/inputmap.h b/Baikal/SceneGraph/inputmap.h
@@ -39,7 +39,7 @@ namespace Baikal
         using Ptr = std::shared_ptr<InputMap>;
         enum class InputMapType
         {
-            kConstantFloat3 = 0, // Holds constant float3 value.
+            kConstantFloat3 = 0, // Holds constant float3 value. 
             kConstantFloat, // Holds constant float value
             kSampler, // Samples value from provided texture
             kAdd, // a + b
@@ -82,7 +82,5 @@ namespace Baikal
         virtual void GetLeafs(std::set<Ptr> &leafs) {};
         // Checks if object is leaf or not
         virtual bool IsLeaf() const { return false;}
-
-        virtual ~InputMap() { }
     };
 }
diff --git a/BaikalStandalone/Application/uber_node.cpp b/BaikalStandalone/Application/uber_node.cpp
@@ -815,6 +815,8 @@ UberNode::UberNode(InputMap::Ptr input_map, UberNode::Ptr parent)
     :m_input_map(input_map), m_parent(parent), m_id(m_next_id++)
 {  }
 
+UberNode::~UberNode() = default;
+
 UberNode_Arg::UberNode_Arg(InputMap::Ptr input_map, UberNode::Ptr parent)
               : UberNode(input_map, parent)
 {

diff --git a/BaikalStandalone/Application/uber_node.h b/BaikalStandalone/Application/uber_node.h
@@ -72,6 +72,8 @@ class UberNode
 
     int GetParentId() const;
 
+    virtual ~UberNode();
+
 protected:
     UberNode(InputMap::Ptr input_map, UberNode::Ptr parent);