Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to set owner in WPF and Windows Forms #617

Merged
merged 3 commits into from
May 10, 2023

Conversation

Fruchtzwerg94
Copy link
Contributor

Added option to set owner in WPF and Windows Forms to prevent hidden popups if owner is top most.

@ravibpatel
Copy link
Owner

I tested this out and find out that I can set the TopMost to true for all the forms, and it has the same effect. Update windows should be always on top anyway, so I think it will be much better because user don't have to set the owner manually. What do you think about this?

@Fruchtzwerg94
Copy link
Contributor Author

Fruchtzwerg94 commented May 5, 2023

I personally do not like to set all Forms to TopMost by default. Here are some reasons why I think like this:

  • Setting the dialogs to TopMost by default could disturb some users which are working in other windows, postponing the update decision to later
  • Setting the dialogs to TopMost by default could suddenly pop up (also if another application is in front) which could lead to wrong inputs if the user does not recognize it fast enough
  • MessageBoxes are not handled as TopMost anyway with this approach
  • Setting the Owner (which is still optionally) clearly assigns the popups to a corresponding application window

… in WPF Window when System.Windows.Form is not referenced.
@ravibpatel
Copy link
Owner

Your points are valid. I added some changes to it to prevent an issue shown here.

@Fruchtzwerg94
Copy link
Contributor Author

Good catch, that was definitively not in my mind. Good to test in different environments / projects.

@ravibpatel ravibpatel merged commit ba8167a into ravibpatel:master May 10, 2023
ravibpatel pushed a commit that referenced this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants