Once download complete , autoupdater not close the running programm first. the update failed #11

ghost · 2017-05-03T02:39:56Z

Once download complete , autoupdater not close the running programm first. the update failed

The autoupdater just restat running programm, and it still old version , not update to latest version.

so why not close running program, then update, then start new program.

ravibpatel · 2017-05-03T05:16:33Z

If you see the source code it just does that. Which type of application are you developing (WPF, Winforms, Console etc.)?

ghost · 2017-05-03T13:17:21Z

winforms.
https://github.com/netroby/border-less-browser/blob/master/BorderLessBrowser/BrowserForm.cs

I am sure it does not close program, the updater hang up .

ghost · 2017-05-03T13:31:55Z

https://github.com/ravibpatel/AutoUpdater.NET/blob/master/AutoUpdater.NET/DownloadUpdateDialog.cs#L83

can you please provide an api to force exit the parent process/application

ghost · 2017-05-03T13:35:22Z

for Example.

Autoupdate.OnDownloadComplete(()=>Application.Exit())

ghost · 2017-05-03T13:47:50Z

https://github.com/ravibpatel/AutoUpdater.NET/blob/master/AutoUpdater.NET/DownloadUpdateDialog.cs#L66

The problem is this . you really should close the running parent programm, then you can run zip extract . or the zip extract would not override the running files

ravibpatel · 2017-05-04T12:11:56Z

https://github.com/ravibpatel/AutoUpdater.NET/blob/master/AutoUpdater.NET/DownloadUpdateDialog.cs#L74-L90

If you see above those lines are dedicated to doing just that. Close currently running application.

ghost · 2017-05-04T12:17:37Z

sorry. it not works. but i found other solution On Thu, May 4, 2017 at 8:11 PM +0800, "Ravi Patel" <[email protected]> wrote: https://github.com/ravibpatel/AutoUpdater.NET/blob/master/AutoUpdater.NET/DownloadUpdateDialog.cs#L74-L90 If you see above those lines are dedicated to doing just that. Close currently running application. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

guillaumejay · 2017-05-30T16:06:43Z

I have the same problem with a WPF app (using currently click once, but autoupdater is only used when not clickonce-launched), and if I don't kill manually the application, autoupdater is not able to kill it.

I'm wondering if there's an event I should use to kill my application gracefully by itself.

(I think I can send you my application if needed to check what is happening..)

ravibpatel · 2017-05-31T05:13:19Z

@guillaumejay Yeah, if you can provide me with the application I can see what is the issue.

guillaumejay · 2017-05-31T10:02:43Z

Would it be relevant if I only send (where) you the relevant exe (and its dll) ?

We worked a bit and found two things :

if we add a one second Sleep() in the zipExtracting window, our (specially-restricted version without cefsharp (see below) ) application can be updated : I think our application is too slow to close.
in our (real) application we're using CefSharp, and it seems it opens lots of sub-process (of course, since it's Chrome) which seem to be not closed by AutoUpdate - which I do not find suprising, because I remember that once upon a time, I had trouble with just closing normally my application => so I'm going to check further .

ravibpatel · 2017-05-31T10:06:22Z

@guillaumejay As long as I can test AutoUpdate part it's completely fine if you send only relevant exe and DLL.

guillaumejay · 2017-05-31T14:01:39Z

I sent you a message using uservoice. Thanks for any help you can bring.
I'll try to take a look on my side, I'm not sure my app is well optimized.

JasonXtreme · 2017-06-09T09:02:59Z

I want to confirm this issue, as I am experiencing it as well. WPF application, .net 4.0 Client profile - If I manage to click the update button before the application starts, all runs well, once my Initialize function goes through, the update fails and the old version is restarted.

ravibpatel · 2017-06-09T12:51:25Z

@JasonXtreme Do you use CefSharp?

JasonXtreme · 2017-06-09T13:00:16Z

@ravibpatel I do not. I downloaded the source code, found the issue was within ZipExtractor - where you check for (speaking from memory, on my phone) Process.StartInfo.FileName.Equals(args[2]), the FileName was consistently empty (for all 170 processes). Changing StartInfo to MainModule fixed it for me.

ravibpatel · 2017-06-09T16:11:33Z

Nice find. Just read the MSDN and found out the reason for this. My bad for not reading the full doc.

"If you did not use the Start method to start a process, the StartInfo property does not reflect the parameters used to start the process. For example, if you use GetProcesses to get an array of processes running on the computer, the StartInfo property of each Process does not contain the original file name or arguments used to start the process."

Can you open a pull request with that particular change so I can add you as a contributor?

guillaumejay · 2017-06-09T17:22:26Z

Great, I hope it will solve my problem.

…

On Fri, Jun 9, 2017 at 6:11 PM, Ravi Patel ***@***.***> wrote: Nice find. Just read the MSDN and found out the reason for this. My bad for not reading the full doc. "If you did not use the Start method to start a process, the StartInfo property does not reflect the parameters used to start the process. For example, if you use GetProcesses to get an array of processes running on the computer, the StartInfo property of each Process does not contain the original file name or arguments used to start the process." Can you open a pull request with that particular change so I can add you as a contributor? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE-uVmoNJ-XEpUTPIjAsfoF5uIlmKsf1ks5sCW62gaJpZM4NO540> .

JasonXtreme · 2017-06-09T21:32:29Z

Gladly, but it won't be before monday. Cheers!

…

On Jun 9, 2017 18:11, "Ravi Patel" ***@***.***> wrote: Nice find. Just read the MSDN and found out the reason for this. My bad for not reading the full doc. "If you did not use the Start method to start a process, the StartInfo property does not reflect the parameters used to start the process. For example, if you use GetProcesses to get an array of processes running on the computer, the StartInfo property of each Process does not contain the original file name or arguments used to start the process." Can you open a pull request with that particular change so I can add you as a contributor? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABlXXUc2BoVhmQkXt29iL-aZcwpLJmysks5sCW62gaJpZM4NO540> .

ravibpatel · 2017-06-10T05:12:10Z

@guillaumejay I afraid it won't fix your problem. I created a minimal application using CefSharp and Environment.Exit() can't kill it. I am working on a workaround. I will email you a fix when I have it.

guillaumejay · 2017-06-10T05:40:54Z

Did you manually call cef.Shutdown too ?

…

On Sat, Jun 10, 2017 at 7:12 AM, Ravi Patel ***@***.***> wrote: @guillaumejay <https://github.com/guillaumejay> I afraid it won't fix your problem. I created a minimal application using CefSharp and Environment.Exit() can't kill it. I am working on a workaround. I will email you a fix when I have it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE-uVr_Fjf_gJqj5p_L80LlmEeE7tTU2ks5sCiWrgaJpZM4NO540> .

ravibpatel · 2017-06-10T05:43:24Z

@guillaumejay No, but when I tried with Event Application.Current.Shutdown() can kill the application.

stebla27 · 2017-06-13T11:52:41Z

I have the same problem.
In my WPF application sometimes update works and sometimes not. Seems to be a timing issue.
When update fails the application restarts with the same version as before and the update dialog is shown again. Starting update a second time is sometimes working, sometimes the updater hangs forever.
Is there any workaround solution?

ravibpatel · 2017-06-13T17:19:31Z

@stebla27 I got the fix. Just download the Beta from here and try it out. You need to handle ApplicationExitEvent though. I am still working on it so you don't have to do it in future.

AutoUpdater.Start("http:https://rbsoft.org/updates/AutoUpdaterTest.xml");

AutoUpdater.ApplicationExitEvent += delegate
{
  Application.Current.Shutdown();
};

stebla27 · 2017-06-13T20:34:36Z

@ravibpatel
Thanks a lot for fast help. My first tests were positive! The possibility for an ApplicationExitEvent is not so bad. 👍
But I have a feature request for this:
It would be nice if i could cancel update in this event by passing a custom error/info text. Or maybe it is better to specify another Event BeforeApplicationUpdate.
My use case is as follows:
The Auto Update is started when application opens. The user first ignors the update dialog and then starts a long pending operation which should not be aborted. If the user now starts the update I would like to ask him if the current operation should be aborted to start the update or to remind him later.
If I have to abort the operation I can use the ApplicationExitEvent.

ravibpatel · 2017-06-14T04:50:49Z

@stebla27 There is event already available for this purpose. See Handling updates manually section. You can do whatever you want to do before downloading and installing the update in this event. ApplicationExitEvent is not so bad but the idea of adding an another line for it to work bothers me. It should me nice if the developer can add AutoUpdate functionality using just one line.

stebla27 · 2017-07-04T07:39:42Z

The problems unfortunately still exists.
There are still update loops.
The program says, there is an update.
Customer clicks on update.
Old program starts again and says that there are updates available.
It's random.

ravibpatel · 2017-07-04T07:47:41Z

@stebla27 It was happening with the beta I provided earlier too?

stebla27 · 2017-07-04T07:58:18Z

@ravibpatel: As it does not happen on all PCs and it is a timing issue I'm not 100% sure. But with the beta I got no customer reports. After upgrading to the official nuget package (including your fix) the behaviour is just like before.
Sorry for bad message! ;)

ravibpatel · 2017-07-04T08:04:51Z

@stebla27 Problem with the beta is if user use Remind later option then it throws an error when ApplicationExitEvent is called.

ravibpatel · 2017-07-04T08:08:18Z

@stebla27 Which .NET Framework you use and is your application using any third party libraries other than this?

stebla27 · 2017-07-05T15:41:32Z

@ravibpatel .Net Framework 4.5.2
Third Party components:
CommonServiceLocator
Costura.Fody
FontAwesome.WPF
Microsoft.Bcl
morelinq
Newtonsoft.Json
Nito.AsyncEx
Ookii.Dialogs
Pri.LongPath

ravibpatel · 2017-07-06T05:21:27Z

@stebla27 Where you call the Start method (constructor of MainWindow)?

stebla27 · 2017-07-06T10:25:04Z

@ravibpatel Yes in constructor of MainWindow.

stebla27 · 2017-07-06T16:06:26Z

@ravibpatel Regarding the "Remind later" option
A customer also reported an exception in UpdateForm.Designer.cs when he clicks on "Remind me later" and the update notice time has expired.

ravibpatel · 2017-07-06T18:52:11Z

@stebla27 Can't reproduce the Remind Later exception. Did you get the stack trace for the error? Can you share me the location of your XML file? If you can't do it here, you can share it on http:https://rbsoft.uservoice.com.

stebla27 · 2017-07-09T17:04:54Z

@ravibpatel Unfortunately I have no stack trace. Only the information that exception occurred in UpdateForm.Designer.cs.
I can't provide you the location of the XML file as it is stored on an internal server and only accessible from an internal webserver.

ravibpatel · 2017-07-10T08:05:57Z

@stebla27 Can you try the beta from below to see if it fixes your problem?

https://www.dropbox.com/s/xg2543cmlcff04a/AutoUpdater.NET.zip?dl=0

stebla27 · 2017-07-26T19:16:26Z

@ravibpatel: The problem is I can't reproduce it on my machine. I've only see it on customer platforms and here I can't really test.
I checked the code and I have two questions:
In Exit method:
foreach (var process in Process.GetProcessesByName(currentProcess.ProcessName))
{
if (process.Id != currentProcess.Id)
{
process.Kill();
}
}

        if (IsWinFormsApplication)
        {
            Application.Exit();
        }
    #if NETWPF
        else if (System.Windows.Application.Current != null)
        {
            System.Windows.Application.Current.Dispatcher.BeginInvoke(new Action(() => System.Windows.Application.Current.Shutdown()));
        }
    #endif
        else
        {
            Environment.Exit(0);
        }

Should there an additional check if application is already closed?
For example after the BeginInvoke. Or after process.Kill?
Furthermore I'm not sure if the exe can be overwritten directly after closing the process. Sometimes Windows blocks write access for some milliseconds and an I/O exception occurs. Have you implemented a retry behaviour for this?

ravibpatel · 2017-07-27T08:38:32Z

@stebla27 There is an additional check present in ZipExtractor that wait for the process to completely exit before extracting anything from downloaded archive. As you can see here. There is no retry behaviour currently present now but I can write one.

stebla27 · 2017-07-27T12:42:09Z

@ravibpatel : Ok, waiting for the process to exit is OK. You don't need a retry behaviour here.
But when you overwrite the file on extracting (don't know where in your code) it could be that windows hasn't released the file handle yet and you will get an I/O Exception. In this case you have to wait some time and retry it again.
I had the same problem in my application and it is timing dependent when you can write a file after last file access. So even if windows says the process has exited it could be that associated exe can't be overwritten for some miliseconds.
It seems that on slower machines (e.g. no SSD) the error happens more often.

Example:
do
{
//try to load the file
//the file could be not yet ready, so we have to do a retry loop here.
try
{
file = File.OpenText(Path);
retryCount = 0;
}
catch (IOException e)
{
if (File.Exists(Path))
{
if (retryCount == 0)
retryCount = 5;

                        Thread.Sleep(1000);
                    }
                    else
                        throw e;
                }
            }
            while (retryCount-- > 0);

LZong-tw · 2018-03-22T09:07:39Z

I tested AutoUpdater on Windows Embedded POSReady 2009 Version 2.0 SP3(could be seen as XP) with .NET 4.0, and the issue still exists. Although it could success after I tried clicking update button for a few times(maybe 3~5 times), it still can't be acceptable to use.
But when I added

AutoUpdater.ApplicationExitEvent += delegate
{
    Application.Exit();
};

inside the Main UI and after AutoUpdater.Start(updateXMLpath);, the problem seems to be solved pretty well.

ravibpatel added the bug label Jun 9, 2017

ravibpatel closed this as completed in 14b8f68 Jun 15, 2017

moebigit mentioned this issue Aug 4, 2020

Application doesn't exit completely before downloaded file gets executed #398

Closed

Once download complete , autoupdater not close the running programm first. the update failed #11

Once download complete , autoupdater not close the running programm first. the update failed #11

Comments

ghost commented May 3, 2017

ravibpatel commented May 3, 2017

ghost commented May 3, 2017

ghost commented May 3, 2017

ghost commented May 3, 2017 • edited by ghost Loading

ghost commented May 3, 2017

ravibpatel commented May 4, 2017

ghost commented May 4, 2017 via email

guillaumejay commented May 30, 2017 • edited Loading

ravibpatel commented May 31, 2017

guillaumejay commented May 31, 2017

ravibpatel commented May 31, 2017

guillaumejay commented May 31, 2017

JasonXtreme commented Jun 9, 2017

ravibpatel commented Jun 9, 2017

JasonXtreme commented Jun 9, 2017

ravibpatel commented Jun 9, 2017

guillaumejay commented Jun 9, 2017 via email

JasonXtreme commented Jun 9, 2017 via email

ravibpatel commented Jun 10, 2017

guillaumejay commented Jun 10, 2017 via email

ravibpatel commented Jun 10, 2017

stebla27 commented Jun 13, 2017 • edited Loading

ravibpatel commented Jun 13, 2017

stebla27 commented Jun 13, 2017 • edited Loading

ravibpatel commented Jun 14, 2017

stebla27 commented Jul 4, 2017

ravibpatel commented Jul 4, 2017

stebla27 commented Jul 4, 2017 • edited Loading

ravibpatel commented Jul 4, 2017

ravibpatel commented Jul 4, 2017

stebla27 commented Jul 5, 2017 • edited Loading

ravibpatel commented Jul 6, 2017

stebla27 commented Jul 6, 2017

stebla27 commented Jul 6, 2017

ravibpatel commented Jul 6, 2017 • edited Loading

stebla27 commented Jul 9, 2017

ravibpatel commented Jul 10, 2017

stebla27 commented Jul 26, 2017

ravibpatel commented Jul 27, 2017

stebla27 commented Jul 27, 2017 • edited Loading

LZong-tw commented Mar 22, 2018

ghost commented May 3, 2017 •

edited by ghost

Loading

guillaumejay commented May 30, 2017 •

edited

Loading

stebla27 commented Jun 13, 2017 •

edited

Loading

stebla27 commented Jun 13, 2017 •

edited

Loading

stebla27 commented Jul 4, 2017 •

edited

Loading

stebla27 commented Jul 5, 2017 •

edited

Loading

ravibpatel commented Jul 6, 2017 •

edited

Loading

stebla27 commented Jul 27, 2017 •

edited

Loading