Fall-back for wrongly formated content-disposition headers (#610)

Co-authored-by: Florian Hug <[email protected]>
ravibpatel · Mar 31, 2023 · 36b569c · 36b569c
1 parent 7da937e
commit 36b569c
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/AutoUpdater.NET/DownloadUpdateDialog.cs b/AutoUpdater.NET/DownloadUpdateDialog.cs
@@ -101,10 +101,19 @@ private void WebClientOnDownloadFileCompleted(object sender, AsyncCompletedEvent
  CompareChecksum(_tempFile, _args.CheckSum);
  }
 
+ // try to parse the content disposition header if it exists
  ContentDisposition contentDisposition = null;
- if (!string.IsNullOrWhiteSpace(_webClient.ResponseHeaders?["Content-Disposition"]))
+ try
+ {
+ if (!string.IsNullOrWhiteSpace(_webClient.ResponseHeaders?["Content-Disposition"]))
+ {
+ contentDisposition = new ContentDisposition(_webClient.ResponseHeaders["Content-Disposition"]);
+ }
+ } 
+ catch (FormatException)
  {
- contentDisposition = new ContentDisposition(_webClient.ResponseHeaders["Content-Disposition"]);
+ // ignore content disposition header if it is wrongly formated
+ contentDisposition = null;
  }
 
  var fileName = string.IsNullOrEmpty(contentDisposition?.FileName)