Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error #709

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix build error #709

wants to merge 2 commits into from

Conversation

ILab-01
Copy link

@ILab-01 ILab-01 commented Jan 14, 2019

I think we need "#include <unistd.h>" to avoid build error about usleep().
And I think we need "-lboost_system" in "Examples/ROS/ORB_SLAM2/CMakeLists.txt" to avoid link error.

This is my first pull request experience. Thank you.

Add #include <unistd.h> to use usleep(). Add -lboost_system to avoid link error.
@humanoid2050
Copy link

I concur with the fix, but I might suggest ${Boost_SYSTEM_LIBRARY} instead of the direct -lboost_system.

@ILab-01
Copy link
Author

ILab-01 commented Jan 21, 2019

Thank you for your comment.
I add ${Boost_SYSTEM_LIBRARY} instead of -lboost_system.

@s-hemer
Copy link

s-hemer commented Feb 21, 2019

Just ran across that issue too and did the same fixes. In principle, it would have been better to separate the boost system and include changes into two commits. But anyway, +1 for accepting this request !

@s-hemer
Copy link

s-hemer commented Feb 21, 2019

By the way, #628 seems to address the same issue. So maybe you should thing of doing the include at the System.h and manually only there where that header is not included. Not sure which one is the better style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants