Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use cargo-nextest for running tests #717

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

orhun
Copy link
Sponsor Member

@orhun orhun commented Dec 27, 2023

Switch to nextest for running tests.

Motivation:

  • cargo test: 19.332s
  • cargo nextest run: 0.981s

Please note:

@joshka
Copy link
Member

joshka commented Dec 27, 2023

It would be good to be have the fast unit tests run before the slow doc tests.

@orhun
Copy link
Sponsor Member Author

orhun commented Dec 27, 2023

Good idea, done in 39e5d45

What we can also do is running them in parallel, but then we get a bunch of "Blocking waiting for file lock on package cache" and the speedup is not significant.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee54493) 91.9% compared to head (39e5d45) 91.9%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #717   +/-   ##
=====================================
  Coverage   91.9%   91.9%           
=====================================
  Files         42      42           
  Lines      14042   14042           
=====================================
  Hits       12915   12915           
  Misses      1127    1127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshka
Copy link
Member

joshka commented Dec 27, 2023

What we can also do is running them in parallel, but then we get a bunch of "Blocking waiting for file lock on package cache" and the speedup is not significant.

Probably best to avoid that.

@joshka joshka merged commit 8d77b73 into ratatui-org:main Dec 27, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants