Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(format): lint markdown #1131

Merged
merged 6 commits into from
Aug 3, 2024
Merged

style(format): lint markdown #1131

merged 6 commits into from
Aug 3, 2024

Conversation

joshka
Copy link
Member

@joshka joshka commented May 24, 2024

  • chore: Fix line endings for changelog
  • chore: cleanup markdown lints
  • ci: add Markdown linter
  • build: add markdown lint to the makefile

cliff.toml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@orhun
Copy link
Sponsor Member

orhun commented May 24, 2024

Commit scope might be style(format): ... for this one, just a thought.

@joshka joshka changed the title fix: lint markdown style(format): lint markdown May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.5%. Comparing base (29c8c84) to head (7e2aab5).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1131   +/-   ##
=====================================
  Coverage   94.5%   94.5%           
=====================================
  Files         65      65           
  Lines      15450   15450           
=====================================
  Hits       14615   14615           
  Misses       835     835           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshka joshka requested a review from orhun May 25, 2024 00:19
@orhun
Copy link
Sponsor Member

orhun commented Aug 3, 2024

rebased on main and fixed conflicts

@orhun orhun merged commit a80a8a6 into main Aug 3, 2024
38 checks passed
@orhun orhun deleted the jm/markdown-lint branch August 3, 2024 17:26
Copy link

github-actions bot commented Aug 3, 2024

🐰Bencher

ReportSat, August 3, 2024 at 17:36:03 UTC
ProjectRatatui
Branch1131/merge
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
barchart/render/2048➖ (view plot)174,120.00
barchart/render/256➖ (view plot)111,750.00
barchart/render/64➖ (view plot)69,740.00
barchart/render_grouped/2048➖ (view plot)319,150.00
barchart/render_grouped/256➖ (view plot)118,750.00
barchart/render_grouped/64➖ (view plot)106,040.00
barchart/render_horizontal/2048➖ (view plot)155,220.00
barchart/render_horizontal/256➖ (view plot)73,121.00
barchart/render_horizontal/64➖ (view plot)66,899.00
block/render_all_feature/100x50➖ (view plot)8,822.90
block/render_all_feature/200x50➖ (view plot)15,642.00
block/render_all_feature/256x256➖ (view plot)70,969.00
block/render_empty/100x50➖ (view plot)4,502.00
block/render_empty/200x50➖ (view plot)9,009.60
block/render_empty/256x256➖ (view plot)58,442.00
line_render/Center/0➖ (view plot)2.48
line_render/Center/10➖ (view plot)393.13
line_render/Center/3➖ (view plot)212.52
line_render/Center/4➖ (view plot)234.36
line_render/Center/42➖ (view plot)488.02
line_render/Center/6➖ (view plot)245.35
line_render/Center/7➖ (view plot)274.40
line_render/Left/0➖ (view plot)2.48
line_render/Left/10➖ (view plot)349.51
line_render/Left/3➖ (view plot)142.94
line_render/Left/4➖ (view plot)151.66
line_render/Left/42➖ (view plot)490.69
line_render/Left/6➖ (view plot)232.59
line_render/Left/7➖ (view plot)240.98
line_render/Right/0➖ (view plot)2.48
line_render/Right/10➖ (view plot)353.10
line_render/Right/3➖ (view plot)211.24
line_render/Right/4➖ (view plot)246.54
line_render/Right/42➖ (view plot)490.22
line_render/Right/6➖ (view plot)318.22
line_render/Right/7➖ (view plot)354.05
list/render/16384➖ (view plot)1,139,400.00
list/render/2048➖ (view plot)250,830.00
list/render/64➖ (view plot)129,190.00
list/render_scroll_half/16384➖ (view plot)1,143,700.00
list/render_scroll_half/2048➖ (view plot)255,360.00
list/render_scroll_half/64➖ (view plot)89,293.00
paragraph/new/2048➖ (view plot)249,100.00
paragraph/new/64➖ (view plot)6,115.00
paragraph/new/65535➖ (view plot)12,910,000.00
paragraph/render/2048➖ (view plot)434,560.00
paragraph/render/64➖ (view plot)393,010.00
paragraph/render/65535➖ (view plot)1,407,100.00
paragraph/render_scroll_full/2048➖ (view plot)388,250.00
paragraph/render_scroll_full/64➖ (view plot)410,400.00
paragraph/render_scroll_full/65535➖ (view plot)1,367,000.00
paragraph/render_scroll_half/2048➖ (view plot)387,230.00
paragraph/render_scroll_half/64➖ (view plot)417,050.00
paragraph/render_scroll_half/65535➖ (view plot)1,362,300.00
paragraph/render_wrap/2048➖ (view plot)218,700.00
paragraph/render_wrap/64➖ (view plot)187,580.00
paragraph/render_wrap/65535➖ (view plot)1,196,800.00
paragraph/render_wrap_scroll_full/2048➖ (view plot)215,430.00
paragraph/render_wrap_scroll_full/64➖ (view plot)188,010.00
paragraph/render_wrap_scroll_full/65535➖ (view plot)1,203,800.00
sparkline/render/2048➖ (view plot)225,830.00
sparkline/render/256➖ (view plot)228,490.00
sparkline/render/64➖ (view plot)72,630.00

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@joshka
Copy link
Member Author

joshka commented Aug 3, 2024

Thanks @orhun :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants