fix(block and several others): deprecate title struct, it's position, and related functions #1061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've deprecated
Title
, thetitle()
function,Position
, and thetitles_position()
function, and adapted the docs to havetitle_top()
andtitle_bottom()
in examples. While it was suggested to addtop_title()
andbottom_title()
, and deprecate the old ones, there's no need becausetitle_top()
andtitle_bottom()
have the same signatures, as the new functions would. It was also suggested that we add thetop_titles
andbottom_titles
fields, this is currently not possible since thetitle()
function supports having titles with no position. So we should rather add the fields after removing the deprecations. I was forced to add#![cfg_attr(test, allow(deprecated)]
tolib.rs
due to a rust bug. And you can ignoreflake.nix
andflake.lock
, it's for Nix users, as I've switched to NixOS recently.