Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new arguments #79

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Added new arguments #79

merged 2 commits into from
Jan 4, 2022

Conversation

askras
Copy link
Contributor

@askras askras commented Dec 3, 2021

Added the following arguments:
--github_username - for prints author github username;
--email - for prints author email;
--website - for prints author or project website.

--github_username - for prints author github username;
--email - for prints author email;
--website - for prints author or project website.
@pep8speaks
Copy link

pep8speaks commented Dec 3, 2021

Hello @askras! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 128:47: E502 the backslash is redundant between brackets
Line 129:32: E127 continuation line over-indented for visual indent

Comment last updated at 2021-12-03 22:21:55 UTC

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

--github_username - for prints author github username;
--email - for prints author email;
--website - for prints author or project website.
@rasbt
Copy link
Owner

rasbt commented Jan 4, 2022

Thanks for the PR! I was thinking whether new string arguments are really necessary vs just adding new line characters, e.g,.

watermark -p pandas,numpy -a "Sebastian Raschka \n Website: www.sebastianraschka.com \n GitHub: @rasbt"

but yeah, I think there is currently no way to make that work afaik. So, I'd say adding those is probably necessary. Thanks!

@rasbt rasbt merged commit 414f14a into rasbt:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants