[FEA] Add distance epilogue for NN Descent #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 17, 2024
tarang-jain
requested changes
Jun 25, 2024
tarang-jain
approved these changes
Jun 25, 2024
tfeher
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Thanks @jinsolp for the PR, it looks good to me!
The only issue is that we are moving nearest neighbor code to cuVS, I have added a note to rapidsai/cuvs#170 to track this.
tfeher
added
improvement
|
Thank you |
|
/ok to test |
|
/ok to test |
divyegala
approved these changes
Jul 7, 2024
|
/ok to test |
1 similar comment
|
/ok to test |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding distance epilogue to NN Descent.
Planning to use them for the following use cases as of now;
L2SqrtExpandeddistance metric, bysqrt-ing the current supported metric (L2Expanded) of NN Descent in the distance epilogue. (for usage with UMAP - related PR here)