Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify git branches to avoid pip unresolvable issues #6869

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

jdye64
Copy link
Contributor

@jdye64 jdye64 commented Dec 1, 2020

Avoid dependency resolution failure in latest version of pip by explicitly specifying versions for dask and distributed

Closes: #6868

@jdye64 jdye64 requested a review from a team as a code owner December 1, 2020 17:46
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@jakirkham
Copy link
Member

Also would grab these

# Install the latest version of dask and distributed
logger "pip install git+https://github.com/dask/distributed.git --upgrade --no-deps"
pip install "git+https://github.com/dask/distributed.git" --upgrade --no-deps
logger "pip install git+https://github.com/dask/dask.git --upgrade --no-deps"
pip install "git+https://github.com/dask/dask.git" --upgrade --no-deps

pip install "git+https://github.com/dask/distributed.git" --upgrade --no-deps
logger "pip install git+https://github.com/dask/dask.git --upgrade --no-deps"
pip install "git+https://github.com/dask/dask.git" --upgrade --no-deps
logger "pip install git+https://github.com/python-streamz/streamz.git --upgrade --no-deps"
pip install "git+https://github.com/python-streamz/streamz.git" --upgrade --no-deps

cudf/ci/gpu/build.sh

Lines 91 to 93 in 69203f1

pip install "git+https://github.com/dask/distributed.git" --upgrade --no-deps
pip install "git+https://github.com/dask/dask.git" --upgrade --no-deps
pip install "git+https://github.com/python-streamz/streamz.git" --upgrade --no-deps

@jdye64
Copy link
Contributor Author

jdye64 commented Dec 1, 2020

ah yes good catch!

…more accurately inform user that 'master' is being installed
@jakirkham
Copy link
Member

Looks good. Thanks!

@jakirkham jakirkham added 6 - Okay to Auto-Merge bug Something isn't working non-breaking Non-breaking change labels Dec 1, 2020
@jakirkham
Copy link
Member

Tried using labels. Hopefully I did that correctly 😁

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #6869 (4609c01) into branch-0.17 (bd537b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.17    #6869   +/-   ##
============================================
  Coverage        81.92%   81.92%           
============================================
  Files               96       96           
  Lines            16167    16167           
============================================
  Hits             13245    13245           
  Misses            2922     2922           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd537b6...4609c01. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 42644cc into rapidsai:branch-0.17 Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cudf_dev environment files result in ResolutionImpossible error during install
4 participants