Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Literals in groupby-agg #16218

Open
wants to merge 2 commits into
base: branch-24.08
Choose a base branch
from
Open

Support Literals in groupby-agg #16218

wants to merge 2 commits into from

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jul 8, 2024 •
edited
Loading

Description

To do this, we just need to collect the appropriate aggregation information, and broadcast literals to the correct size.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Jul 8, 2024
@wence- wence- force-pushed the wence/fea/polars-groupby-literal branch from 1b3f24d to 94b6efe Compare July 9, 2024 13:55
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 9, 2024
@wence- wence- marked this pull request as ready for review July 9, 2024 13:55
@wence- wence- requested a review from a team as a code owner July 9, 2024 13:55
@wence- wence- requested review from vyasr and charlesbluca July 9, 2024 13:55
@wence-
Support literals as both keys and in groupby aggregation expressions
9552381 
This was nearly completely working, we just needed a to implement
collect_agg and handle broadcasting correctly.
@wence-
Support series literals in groupby-agg
867f430 
Needed to implement custom hashing since pyarrow arrays aren't
hashable.
@wence- wence- force-pushed the wence/fea/polars-groupby-literal branch 3 times, most recently from 3e4c457 to 867f430 Compare July 15, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@wence-