Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure cudf::ast::expressions api doesn't use detail types #16217

Draft
wants to merge 5 commits into
base: branch-24.08
Choose a base branch
from

Conversation

robertmaynard
Copy link
Contributor

Description

The public api of cudf::ast::expression required using cudf::ast::detail types which goes against the cudf programming guide. So we move the required types to use cudf::ast::expression into the public stable API.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added feature request New feature or request breaking Breaking change labels Jul 8, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 8, 2024
@robertmaynard robertmaynard force-pushed the move_ast_expression_out_of_detail branch 2 times, most recently from 5dd1c38 to afcb47d Compare July 8, 2024 20:42
@robertmaynard robertmaynard force-pushed the move_ast_expression_out_of_detail branch from b6b0c64 to 5c679cd Compare July 17, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant