Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON tree algorithms refactor I: CSR data structure for column tree #15979

Open
wants to merge 28 commits into
base: branch-24.10
Choose a base branch
from
Open

JSON tree algorithms refactor I: CSR data structure for column tree #15979

wants to merge 28 commits into from
+911 −256

Conversation

shrshi
Copy link
Contributor

@shrshi shrshi commented Jun 11, 2024 •
edited
Loading

Description

Part of #15903.

  1. Introduces the Compressed Sparse Row (CSR) format to store the adjacency information of the column tree.
  2. Analogous to reduce_to_column_tree, reduce_to_column_tree_csr reduces node tree representation to column tree stored in CSR format.

TODO:

  • Correctness test

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 11, 2024
@shrshi shrshi added cuIO cuIO issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 11, 2024
@github-actions github-actions bot added the CMake CMake build issue label Jun 25, 2024
@shrshi shrshi marked this pull request as ready for review June 25, 2024 01:00
@shrshi shrshi requested a review from a team as a code owner June 25, 2024 01:00
@ttnghia
Copy link
Contributor

ttnghia commented Jun 25, 2024

Question: Is this ready for review? Or still WIP?

@shrshi
Copy link
Contributor Author

shrshi commented Jun 25, 2024

Question: Is this ready for review? Or still WIP?

Sorry, forgot to update the title. It's ready for review.

@shrshi shrshi changed the title [WIP] JSON tree algorithms refactor I: CSR data structure for column tree JSON tree algorithms refactor I: CSR data structure for column tree Jun 25, 2024
@shrshi shrshi requested a review from a team as a code owner June 28, 2024 17:21
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 28, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shrshi
Copy link
Contributor Author

shrshi commented Jun 28, 2024

/ok to test

@shrshi shrshi mentioned this pull request Jul 6, 2024
Draft
8 tasks
@shrshi shrshi requested review from a team as code owners July 30, 2024 22:10
@shrshi shrshi requested review from bdice and vyasr and removed request for a team July 30, 2024 22:10
@github-actions github-actions bot added Python Affects Python cuDF API. Java Affects Java cuDF API. cudf.polars Issues specific to cudf.polars labels Jul 30, 2024
@shrshi shrshi changed the base branch from branch-24.08 to branch-24.10 July 30, 2024 22:11
@github-actions github-actions bot removed Python Affects Python cuDF API. Java Affects Java cuDF API. cudf.polars Issues specific to cudf.polars labels Jul 30, 2024
@shrshi
Copy link
Contributor Author

shrshi commented Jul 30, 2024

/ok to test

@shrshi
Copy link
Contributor Author

shrshi commented Jul 31, 2024

/ok to test

@shrshi
Copy link
Contributor Author

shrshi commented Jul 31, 2024

/ok to test

@shrshi
Copy link
Contributor Author

shrshi commented Jul 31, 2024

/ok to test

@jameslamb jameslamb removed the request for review from a team August 14, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zpuller zpuller Awaiting requested review from zpuller zpuller is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@davidwendt davidwendt Awaiting requested review from davidwendt davidwendt is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@bdice bdice Awaiting requested review from bdice bdice was automatically assigned from rapidsai/packaging-codeowners

@vyasr vyasr Awaiting requested review from vyasr vyasr was automatically assigned from rapidsai/cudf-python-codeowners

@karthikeyann karthikeyann Awaiting requested review from karthikeyann

@ttnghia ttnghia Awaiting requested review from ttnghia

@vuule vuule Awaiting requested review from vuule

At least 1 approving review is required to merge this pull request.

Assignees

@shrshi shrshi

Labels
CMake CMake build issue cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: In Progress
libcudf
Status: Slip
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shrshi @ttnghia @GregoryKimball @karthikeyann @vuule