Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON reader validation of values #15968

Draft
wants to merge 12 commits into
base: branch-24.10
Choose a base branch
from
Draft

JSON reader validation of values #15968

wants to merge 12 commits into from

Conversation

karthikeyann
Copy link
Contributor

@karthikeyann karthikeyann commented Jun 11, 2024 •
edited
Loading

Description

Addresses part of #15222
This change adds validation stage in JSON reader at tokens level. If any validation fails in a row, it will make the entire row as null.
TODO:

  • validation functor - implement spark validation rules. (only leading zeros check is added).
  • move output iterator to thrust.
  • Fix failing tests and infer data type for Float.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@karthikeyann karthikeyann added feature request New feature or request 2 - In Progress Currently a work in progress cuIO cuIO issue Spark Functionality that helps Spark RAPIDS labels Jun 11, 2024
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Jun 11, 2024
@karthikeyann karthikeyann changed the title JSON validation of Values JSON reader validation of values Jun 11, 2024
@karthikeyann karthikeyann added the non-breaking Non-breaking change label Jun 13, 2024
@github-actions github-actions bot added the Java Affects Java cuDF API. label Aug 2, 2024
@karthikeyann karthikeyann changed the base branch from branch-24.08 to branch-24.10 August 2, 2024 21:14
@karthikeyann karthikeyann marked this pull request as ready for review August 9, 2024 20:32
@karthikeyann karthikeyann requested review from a team as code owners August 9, 2024 20:32
@karthikeyann karthikeyann marked this pull request as draft August 9, 2024 20:32
@karthikeyann karthikeyann mentioned this pull request Aug 14, 2024
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 Awaiting requested review from revans2

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@vuule vuule Awaiting requested review from vuule vuule is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

@karthikeyann karthikeyann

Labels
2 - In Progress Currently a work in progress CMake CMake build issue cuIO cuIO issue feature request New feature or request Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
cuDF/Dask/Numba/UCX
Status: In Progress
libcudf
Status: Slip
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karthikeyann @revans2