Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] write_index_stream in ORC writer indexing error #6401

Closed
vuule opened this issue Oct 2, 2020 · 0 comments · Fixed by #6807
Closed

[BUG] write_index_stream in ORC writer indexing error #6401

vuule opened this issue Oct 2, 2020 · 0 comments · Fixed by #6807
Assignees
@rgsl888prabhu
Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code.
Projects
v0.17 Release

Comments

@vuule
Copy link
Contributor

vuule commented Oct 2, 2020

According to the comment #6342 (comment), there is an error in line

cudf/cpp/src/io/orc/writer_impl.cu

Line 868 in 86804ef

while ((record[1] >= 0) && (static_cast<size_t>(record[0]) >= compression_blocksize_) &&

In addition, there is a lack of test coverage for both this issue and #6333.
The test(s) should be added as part of this fix.

Note: the comment above also suggests replacing std::arrays in the write_index_stream with structs to improve code clarity. This can also be addressed in the same PR.
@vuule vuule added bug Something isn't working Needs Triage Need team to review and classify cuIO cuIO issue labels Oct 2, 2020
@github-actions github-actions bot added this to Needs prioritizing in Bug Squashing Oct 2, 2020
@harrism harrism added this to Issue-Needs prioritizing in v0.17 Release via automation Oct 2, 2020
@kkraus14 kkraus14 added libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Oct 8, 2020
@kkraus14 kkraus14 removed this from Needs prioritizing in Bug Squashing Oct 8, 2020
@harrism harrism moved this from Issue-Needs prioritizing to Issue-P0 in v0.17 Release Oct 15, 2020
@vuule vuule moved this from Issue-P0 to Issue-P1 in v0.17 Release Oct 16, 2020
@rgsl888prabhu rgsl888prabhu mentioned this issue Nov 19, 2020
Merged
@rapids-bot rapids-bot bot closed this as completed in #6807 Dec 2, 2020
v0.17 Release automation moved this from Issue-P1 to Done Dec 2, 2020
rapids-bot bot pushed a commit that referenced this issue Dec 2, 2020
@rgsl888prabhu
Refactor std::array usage in row group index writing in ORC(#6807)
ff66c5e 
Replaced std::array with named struct.
closes #6401

Authors:
  - Ramakrishna Prabhu <[email protected]>
  - Vukasin Milovanovic <[email protected]>
  - Karthikeyan <[email protected]>

Approvers:
  - Vukasin Milovanovic
  - Karthikeyan
  - Keith Kraus

URL: #6807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgsl888prabhu rgsl888prabhu

Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code.
Projects
No open projects
v0.17 Release
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor std::array usage in row group index writing in ORC rgsl888prabhu/cudf
3 participants
@kkraus14 @vuule @rgsl888prabhu