Add framework target/shared scheme for Carthage Support #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… version requirement to 9.0 in both README and framework
|
Thank you @ynnadrules for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #6.
Because of the way the project was structured, I added a new Framework target named
SwiftIconsand renamed the existing Application targetSwiftIconsApp.I also had to
import SwiftIconswhere needed in SwiftIconsApp.I moved all the
.ttffont files intoSource/Fonts, just to organize it a little better.In
SwiftIcons.swift, for each of the font type enums, I had to make the staticcountcomputed functionpublicso the SwiftIconsApp could have access to it.Question, btw: What is being used to generate the code for the font type enum and related variables in
SwiftIcons.swift?