-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KDF + BLAKE discrepancies #2525
Comments
Yikes. Thanks. If nothing else that suggests a hole in the test suite, that this change was completely missed. |
KDF and PBKDF2 both have logic for accepting either a MAC name or a hash name (in which case HMAC with that hash is used). However the logic was to first try creating it as a MAC, then falling back to HMAC, so when BLAKE2b was added as a MAC both your examples switched to using keyed BLAKE2 instead of BLAKE2 with HMAC. Fix is just to switch these. |
HKDF fixed, still seeing discrepancies with PBKDF2, eg:
|
@guidovranken There was one place I missed making the necessary change, should be resolved now. |
The behavior of KDFs with BLAKE is different since your recent BLAKE-related commits. So far I've observed discrepancies with other libraries with HKDF and PBKDF2, but there could be others as well.
Output previously (commit 378072e):
Output now (commit 83c949d):
The text was updated successfully, but these errors were encountered: