Refactor Session serveMessage and mutex usage #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: 44576
Extracted a few modifications required in during the review of #74.
session.serveMessage
for the sake of simplicity. It now just parses the raw message and calls the appropriate method, and also moved relevant methods to an independent file.sync.Mutex
inSession
with aRWMutex
. Also, creating new methods to interact with the protected map, hence avoiding (most) of the callers to lock and unlock.wsConn
into an interface, converting the existingwsConn
intowsWrapper
. This eases testing.