-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated User-Agent header logic #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
50b53b9
to
78e74fa
Compare
@rakyll is there any chance to get this merged? Setting the user-agent would allow Flagger load generator service to work for A/B testing scenarios when the test is based on browser/os versions. Thanks |
on command line the option -H "User-Agent: CustomUserAgent" is ignored and default user agent is always used First check if its defined then fallback to default ref rakyll#87 fix rakyll#157
@rakyll Maybe, you should publish a release version. 😢 |
How do I implement the UA update? I tried to download the repository, but couldn't compile and run the go script. Is there any release version? |
This update will append the original UA so you end up with something like
I just very quickly threw up a fork that will completely replace the UA, with installation instructions in the readme: |
Hey
Thanks for your help!
I tried installing it by following the readme instructions. While trying to
run the "go get..." I got this error:
unrecognized import path "net/http/httptrace" (import path does not begin
with hostname)
Is there anything else I should do?
Thank you
…On Thu, Dec 8, 2022 at 2:30 AM lindsey-em ***@***.***> wrote:
This update will append the original UA so you end up with something like new
ua hey/0.0.1:
// set userAgent header if set
if *userAgent != "" {
ua = *userAgent + " " + heyUA
header.Set("User-Agent", ua)
}
I just very quickly threw up a fork that will completely replace the UA,
with installation instructions in the readme:
https://github.com/lindsey-em/hey
—
Reply to this email directly, view it on GitHub
<#87 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXZ5357FRU4WR37GIL3XFVLWMET2VANCNFSM4ENOA7AQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
*ZIV ELYASHIV*
DDoS Expert
*E: ***@***.***
*M: *+972-(0)50-3213330
[image: Red Button]
[image: Under DDoS Attack? Click here for IMMEDIATE ASSISTANCE]
<https://www.red-button.net/>
*www.red-button.net* <https://www.red-button.net/>
[image: Blog] <https://www.red-button.net/blog/>
<https://www.linkedin.com/companies/red-button-ddos-experts> [image:
youtube] <https://www.youtube.com/channel/UCNDr_afX7_e-ityDrjF5DBQ>
This e-mail message may contain confidential or legally privileged
information and is intended only for the use of the intended recipient(s).
Any unauthorized disclosure, dissemination, distribution, copying or the
taking of any action in reliance on the information herein is prohibited.
E-mails are not secure and cannot be guaranteed to be error free as they
can be intercepted, amended, or contain viruses. Anyone who communicates
with us by e-mail is deemed to have accepted these risks. Red Button is not
responsible for errors or omissions in this message and denies any
responsibility for any damage arising from the use of e-mail. Any opinion
and other statement contained in this message and any attachment are solely
those of the author and do not necessarily represent those of the company.
|
Issue/Request:
The User-Agent header was not set when passed as a HTTP header param. Added the ability to set User-Agent via header and/or separate CLI parameter
-U
.