Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added detailed report and csv support for httptrace fields #22

Merged
merged 1 commit into from
Oct 19, 2016

Conversation

jronak
Copy link
Contributor

@jronak jronak commented Sep 18, 2016

No description provided.

if len(r.errorDist) > 0 {
r.printErrors()
if r.trace {
fmt.Printf("\nDetailed Report:\n")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is too much info. i am not sure if we want to show a breakdown for all latencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can avoid displaying histogram, instead display the average, fastest and slowest?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoiding to display histogram sounds good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@jronak jronak changed the title added histogram and csv support for httptrace fields added detailed report and csv support for httptrace fields Oct 16, 2016
@rakyll rakyll merged commit edbda8a into rakyll:master Oct 19, 2016
@rakyll
Copy link
Owner

rakyll commented Oct 19, 2016

Thankss!!

chunter0 pushed a commit to chunter0/hey that referenced this pull request Apr 8, 2024
Support cmd/go-httpbin (👍) and cmd/go_httpbin (👎)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants