Moving strategy to separate package + refactor

service/app/generate_pricing.go

@@ -5,6 +5,7 @@ import (
  "log"
 
  "pricingengine"
+ "pricingengine/service/strategy"
  "pricingengine/service/config"
 )
 
@@ -44,7 +45,7 @@ func (a *App) GeneratePricing(ctx context.Context, request *pricingengine.Genera
  return &result, nil
  }
 
- var strategies = Strategy{}
+ var strategies = strategy.Strategy{}
  driver_factor_range, err := strategies.FindMatchingDriverAgeFactor(request, a.Cache.DriverAgeFactorList)
  if(err != nil) {
  log.Printf("error finding driver_factor_range: %v", err)
@@ -104,7 +105,10 @@ func (a *App) GeneratePricing(ctx context.Context, request *pricingengine.Genera
 // Just forms a map[]{} based on the config in the cache
 func (a *App) GeneratePricingConfig(ctx context.Context) (interface{}, error) {
  log.Println("Entering GeneratePricingConfig")
- a.Cache.Fetcher = config.ConfigFetcher{Path: "/config/"} // Initialise with actual path
+ // Initialise with actual path if not present
+ if a.Cache.TimeToLive == 0 {
+ a.Cache.Fetcher = config.ConfigFetcher{Path: "/config/"}
+ }
  a.Cache.InitialiseWithRefresh(false, 100000) // time to live 100000s
  var result map[string]interface{} = make(map[string]interface{})
 

service/app/pricing_strategy.go → service/strategy/pricing_strategy.go

@@ -1,4 +1,4 @@
-package app
+package strategy
 
 import (
  "log"

test/app/app_test.go

@@ -23,7 +23,7 @@ func TestPriceGenerationAppWithActualConfigs(tp *testing.T){
  }
  tp.Run("TestPriceGenerationAppToGetValidGeneratedPriceList-FailureScenario-1", func(t *testing.T) {
  resp,_ := testApp.GeneratePricing(context.Background(),&pricingengine.GeneratePricingRequest{})
- println(resp)
+
  util.AssertFalse(resp.IsEligible, t)
  util.AssertEqual(len(resp.PricingList), 0, t)
  util.AssertTrue(len(resp.Message) > 0, t)
@@ -35,7 +35,7 @@ func TestPriceGenerationAppWithActualConfigs(tp *testing.T){
  DateOfBirth: "2006-01-02",
  }
  resp,_ := testApp.GeneratePricing(context.Background(),&request)
- println(resp)
+
  util.AssertFalse(resp.IsEligible, t)
  util.AssertEqual(len(resp.PricingList), 0, t)
  util.AssertTrue(len(resp.Message) > 0, t)
@@ -49,7 +49,7 @@ func TestPriceGenerationAppWithActualConfigs(tp *testing.T){
  InsuranceGroup: 20,
  }
  resp,_ := testApp.GeneratePricing(context.Background(),&request)
- println(resp)
+
  util.AssertFalse(resp.IsEligible, t)
  util.AssertEqual(len(resp.PricingList), 0, t)
  util.AssertTrue(len(resp.Message) > 0, t)
@@ -64,7 +64,7 @@ func TestPriceGenerationAppWithActualConfigs(tp *testing.T){
  LicenseHeldSince: "2006-01-02",
  }
  resp,_ := testApp.GeneratePricing(context.Background(),&request)
- println(resp)
+
  util.AssertFalse(resp.IsEligible, t)
  util.AssertEqual(len(resp.PricingList), 0, t)
  util.AssertTrue(len(resp.Message) > 0, t)
@@ -79,7 +79,7 @@ func TestPriceGenerationAppWithActualConfigs(tp *testing.T){
  LicenseHeldSince: "2006-01-02",
  }
  resp,_ := testApp.GeneratePricing(context.Background(),&request)
- println(resp)
+
  util.AssertFalse(resp.IsEligible, t)
  util.AssertEqual(len(resp.PricingList), 0, t)
  util.AssertTrue(len(resp.Message) > 0, t)
@@ -95,7 +95,7 @@ func TestPriceGenerationAppWithActualConfigs(tp *testing.T){
  LicenseHeldSince: "2006-01-02",
  }
  resp,_ := testApp.GeneratePricing(context.Background(),&request)
- println(resp)
+
  util.AssertTrue(resp.IsEligible, t)
  util.AssertEqual(len(resp.PricingList), 2, t)
  util.AssertEqual(resp.Message, "Success", t)
@@ -119,7 +119,7 @@ func TestPriceGenerationAppWithActualConfigs(tp *testing.T){
  LicenseHeldSince: "2020-01-02",
  }
  resp,_ := testApp.GeneratePricing(context.Background(),&request)
- println(resp)
+
  util.AssertTrue(resp.IsEligible, t)
  util.AssertEqual(len(resp.PricingList), 2, t)
  util.AssertEqual(resp.Message, "Success", t)