Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kaminary param_name for pagination #3227

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

RodrigoPereyraDiaz
Copy link
Contributor

Kaminary has a configuration to custom param_name, and this change use that configuration like does Main index instead of use hard code :page name

History index only allow use :page parameter name.
Kaminary has a configuration to custom param_name, and this change use that configuration like does in [Main index](https://github.com/sferik/rails_admin/blob/9abc1be0c1fee006a7a746583461891911fe9330/app/controllers/rails_admin/main_controller.rb#L125)
@mshibuya
Copy link
Member

Thanks, but we need test code for this!

@mshibuya mshibuya added this to the 3.0.0 milestone Aug 8, 2021
mshibuya added a commit that referenced this pull request Oct 11, 2021
@mshibuya mshibuya merged commit 0a4b6c1 into railsadminteam:master Oct 11, 2021
@mshibuya
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants