Fix the case where username is nil, not whodunnit #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you write a spec for this issue? |
|
@mshibuya I'd like to add tests but CI seems to fail. Could you fix it? |
|
It's already fixed in the master. |
|
@mshibuya Great, thanks! |
I encounter the problem where paper_trails's whodunnit isn't displayed. It turned out that `username` method returns nil. `try` method returns nil when there's no method, so when user doesn't have `email` method, `@user_class.find(@version.whodunnit).try(:email)` returns nil. Then, try this out: `nil rescue nil || :foo` This returns nil, surprisingly. This means if user doesn't have email method, username is always nil. So my fix is like below: `(nil rescue nil) || :foo` This returns `:foo` as expected.
8e85881
to
5f35e90
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encounter the problem where paper_trails's whodunnit isn't displayed.
It turned out that
usernamemethod returns nil.trymethod returns nil when there's no method, so when user doesn't haveemailmethod,@user_class.find(@version.whodunnit).try(:email)returns nil.Then, try this out:
nil rescue nil || :fooThis returns nil, surprisingly.
This means if user doesn't have email method, username is always nil.
So my fix is like below:
(nil rescue nil) || :fooThis returns
:fooas expected.