fixes issue #2919 #3006
Merged
fixes issue #2919 #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing cookie middleware when rails is used in api mode
|
Merged in, thanks! |
This was referenced Jul 16, 2018
|
@mshibuya Adding the cookie middleware overwrote the code that I had in config/initializers/session_store.rb. I had my own cookie name but it defaulted back to '_session_id' . I am using Rails 4.2.10. This is a fix for Rails 5 but i believe it caused problem for me in Rails 4 . Quick solution was adding the 'middleware config' to application.rb, but the _session_id was persistent along with my custom cookie. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing cookie middleware when rails is used in api mode
I am not entirely sure if this is the correct way to go about this. My rails engine knowledge is limited. Will this also add these middlewares to the main application or just this engine (rails_admin) ?