Fix regexp for converting rails date format to momentjs #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not open&close PR repeatedly. If you find problem with your PR, just push new commit to original branch(then your PR will be updated). Additionally, can you write some specs for this fix? |
|
Sorry for that. Yes I will write some specs. |
|
@mshibuya test added |
|
Nice ❤️ |
|
@mshibuya done 👍 |
mshibuya
added a commit
that referenced
this pull request
Nov 2, 2015
Fix regexp for converting rails date format to momentjs
|
Thank you 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #982