Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model label should be pluralized with locale #1983

Merged
merged 1 commit into from
Feb 4, 2016
Merged

Model label should be pluralized with locale #1983

merged 1 commit into from
Feb 4, 2016

Conversation

Kabie
Copy link
Contributor

@Kabie Kabie commented May 8, 2014

Right now it uses locale: :en. So it might be incorrectly pluralized.

Right now it uses `locale: :en`. So it might be incorrectly pluralized.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.24%) when pulling 0333946 on Kabie:patch-1 into 6ca05c6 on sferik:master.

@mshibuya
Copy link
Member

Could you please write some test?

@bbenezech
Copy link
Collaborator

Good catch!
@mshibuya Current behavior test should be more than enough.

https://apidock.com/rails/ActiveSupport/Inflector/pluralize

bbenezech added a commit that referenced this pull request Feb 4, 2016
Model label should be pluralized with locale
@bbenezech bbenezech merged commit ca98cbb into railsadminteam:master Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants