Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Thor::CoreExt::HashWithIndifferentAccess#slice method #812

Merged
merged 3 commits into from
May 15, 2023

Conversation

shuuuuun
Copy link
Contributor

resolve #804

This PR supports Thor::CoreExt::HashWithIndifferentAccess#slice.

hash = Thor::CoreExt::HashWithIndifferentAccess.new 'foo' => 'bar', 'baz' => "bee"
hash.slice('foo')
# => {"foo"=>"bar"}
hash.slice(:foo)
# => {"foo"=>"bar"}

Thank you. 🌈

@shuuuuun
Copy link
Contributor Author

Oh, this gem needs to support from Ruby 2.0...

@shuuuuun
Copy link
Contributor Author

@rafaelfranca
Copy link
Member

rafaelfranca commented May 11, 2023

Can you rebase this PR now?

@shuuuuun
Copy link
Contributor Author

shuuuuun commented May 12, 2023

I have rebased the PR!
It looks like the CI fail is the same as the one currently occurring in the main branch.
https://github.com/rails/thor/actions/runs/4953317981

I'll rebase again once the issue is resolved in the main branch.

@rafaelfranca
Copy link
Member

Fixed

@rafaelfranca rafaelfranca merged commit d8b073c into rails:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How about supporting Thor::CoreExt::HashWithIndifferentAccess#slice method?
2 participants