Support Thor::CoreExt::HashWithIndifferentAccess#except for Rails 6.0
#734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR supports `Thor::CoreExt::HashWithIndifferentAccess#except`
and prevents breaking changes in Rails upgrades when using
`options.except(:key)` in Thor task.
When Thor is used with Rails (Active Support), the behavior changes as follows.
## With Rails 5.2 or lower
```ruby
h = Thor::CoreExt::HashWithIndifferentAccess.new(foo: 1, bar: 2)
h.except(:foo) #=> {"bar"=>2}
```
## With Rails 6.0
```ruby
h = Thor::CoreExt::HashWithIndifferentAccess.new(foo: 1, bar: 2)
h.except(:foo) #=> {"foo"=>1, "bar"=>2}
```
This difference behavior is due to the following changes in Rails 6.0.
rails/rails#35771
This PR makes the behavior between Rails 5.2 and Rails 6.0 compatible.
koic
changed the title
Thor::CoreExt::HashWithIndifferentAccess#exceptThor::CoreExt::HashWithIndifferentAccess#except for Rails 6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports
Thor::CoreExt::HashWithIndifferentAccess#exceptand prevents breaking changes in Rails upgrades when usingoptions.except(:key)in Thor task.When Thor is used with Rails (Active Support), the behavior changes as follows.
With Rails 5.2 or lower
With Rails 6.0
This difference behavior is due to the following changes in Rails 6.0.
rails/rails#35771
This PR makes the behavior between Rails 5.2 and Rails 6.0 compatible.