Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: drop support for Rack < 3 #52206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

wip: drop support for Rack < 3 #52206

wants to merge 1 commit into from

Conversation

zzak
Copy link
Member

@zzak zzak commented Jun 24, 2024

Fixes #50565

One thing I'd like to figure out in this PR is rack/rack#2137, so still investigating. This is more just an FYI, if folks would like to help.

@rails-bot rails-bot bot added the actionpack label Jun 24, 2024
@Earlopain
Copy link
Contributor

Well, that deprecation for the status code was reverted for 3.1 but that doesn't really help when rails is testing against main. Something like #52097 needs to be done regardless. I don't think it was finished though, seems to have missed a few instances (apart from docs).

@ioquatix
Copy link
Contributor

I've been discussing this with @zzak and I think we'd be okay with dropping the deprecation warnings from 3.2 and re-introducing them in Rack 3.3, that gives us 12 months to sort out Rails in terms of what's running on head, and ~24 months for what's actually released, before we start issuing deprecation warnings.

@zzak
Copy link
Member Author

zzak commented Jun 24, 2024

There is also rails/buildkite-config/#110 to update the CI matrix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require Rack 3
3 participants