-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add form_with to unify form_tag/form_for. #26976
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
18a44be
Add form_with to unify form_tag/form_for.
kaspth c0df7c6
Code climatize.
kaspth 1e7e5cb
Add fields DSL method.
kaspth a4a5945
Document form_with.
kaspth 31a9608
Enable remote by default.
kaspth 3a55155
Readd commented out tests.
kaspth b714aa8
[ci skip] Document the fields helpers.
kaspth e3eb691
Link to `fields` helper method docs.
kaspth 5a4052a
[ci skip] Documentation edits.
kaspth 7d6fc1f
Use ERB tags.
kaspth 694c226
[ci skip] Remove nested attributes examples
kaspth 407d9f2
Invert `include_id` to `skip_id`.
kaspth 42f4fb2
Invert `remote` to `local`.
kaspth 15a805c
Invert `enforce_utf8` to `skip_enforcing_utf8`.
kaspth 17429bb
Refer to the brand spanking new rails-ujs.
kaspth 30ebe5d
Make `form_with` a bit more composed.
kaspth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Add form_with to unify form_tag/form_for.
`form_tag` and `form_for` serve very similar use cases. This PR unifies that usage such that `form_with` can output just the opening form tag akin to `form_tag` and can just work with a url, for instance. `form_with` by default doesn't attach class or id to the form — removing them on fields is moved out to a default revisiting PR later. Ported over old tests where applicable to ensure maximum coverage, but left some commented out because they don't yet apply (e.g. `fields_for` later being replaced by `fields`). [ Kasper Timm Hansen & Marek Kirejczyk ]
- Loading branch information
commit 18a44be8b9c13911da21fe2cc95a84e95dee7456
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like wrong output?