Use Node v16.x as v10.x is no longer supported #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest Ruby Docker image upgraded from Debian to Bullseye: docker-library/ruby#357 Bullseye no longer supports Node v10.x, which cause NPM to not be installed, resulting in failing builds. As Node v10.x is no longer supported we should switch to a supported version. Active support for v14 ends in November 2021, so we might as well switch to v16. See: https://endoflife.date/nodejs Steps to reproduce: $ git clone https://github.com/rails/rails $ cd rails $ git clone https://github.com/rails/buildkite-config .buildkite/ $ RUBY_IMAGE=ruby:3.0.2 docker-compose -f .buildkite/docker-compose.yml build base && CI=1 docker-compose -f .buildkite/docker-compose.yml run actionview runner actionview 'rake test:ujs'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Ruby Docker image upgraded Debian to Bullseye:
docker-library/ruby#357
Bullseye no longer supports Node v10.x, which cause NPM to not be
installed, resulting in failing builds.
As Node v10.x is no longer supported we should switch to a supported
version. Active support for v14 ends in November 2021, so we might as
well switch to v16. See: https://endoflife.date/nodejs
Steps to reproduce: