Remove uninitialized constants #173
Open
+0
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These constants were removed from Rack in rack/rack#1720
douglasresende
approved these changes
Feb 7, 2024
|
Had the same thought. Could the PR please conditionally check for a Rack version so it works with either? |
|
I can do that if the original author doesn’t have time. Was going to do it after the other PR was merged then test and see if it breaks older rack versions. I have a deployed app I can test with so it’s an easy test ha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #171. The constants were removed from Rack in rack/rack#1720 so removed them here to prevent the initialized constants error.